A colleague has administered a questionnaire that asked respondents to provide both before and after values and has used the paired sample t-test to check for effect of the intervention on the dependent variable. Is this appropriate? I was of the opinion that there must be two observations that must be performed before and after the intervention. Please advise
Judging from the little information given, the procedure is correct. You have got two metric variables that stem from identical individuals. This alone makes them paired samples that are not i.i.d. and should be investigated with a method for paired samples. The i.i.d. assumption is violated and that is all that matters. Whether one questionnaire was filled in before an intervention or resembles the memory of before the intervention has no influence on statistics. That does not mean, that retrospective questionnaires are of the same scientific value as questionnaires quo ante, but that is a question of methodology, not of statistic test choice.